fix(apache): align template standards by mberlofa · Pull Request #641 · helmforgedev/charts

mberlofa · 2026-07-02T22:03:28Z

Summary

Align the Apache chart with the corrected template standards checker.

Changes:

move the Helm test pod out of templates/tests/ into templates/test-connection.yaml
add canonical networkPolicy.egress.extraEgress support while preserving extraRules
update Apache NOTES sections to the numbered operational pattern
add helm-unittest coverage for the Helm test pod and extraEgress
update chart networking docs for the new NetworkPolicy value

Related issue: Closes #633
Site PR: helmforgedev/site#321

Validation

node C:\devops\berlofa\github\helmforge\helmforge-ops\scripts\charts\template-standards-check.js --chart apache --json
helm unittest charts/apache
make standards-check CHART=apache
make validate-chart CHART=apache
make site-sync-check CHART=apache
make release-check REPO=charts
make attribution-check REPO=charts

Result: apache: FULLY VALIDATED (20 layers) including k3d behavioral validation for default and all ci/*.yaml scenarios.

Summary by CodeRabbit

New Features
- Added support for extending NetworkPolicy egress rules with an additional extraEgress configuration.
- Included an example showing how to define extra egress destinations and ports.
Documentation
- Updated chart notes with clearer, numbered section headings.
- Expanded NetworkPolicy guidance to cover the new egress option.
Tests
- Added coverage for custom egress rules and chart connection checks.

github-actions · 2026-07-02T22:03:47Z

Standards Check (GR-079) — PASS

Every changed chart fully passes standards-check.

coderabbitai · 2026-07-02T22:03:49Z

📝 Walkthrough

Walkthrough

This PR aligns the apache chart with template standards: adds an extraEgress NetworkPolicy configuration (values, template, docs, tests), renumbers NOTES.txt section headings 1–9, and adds a new test-connection Helm test suite.

Changes

Apache Chart Template Standards Alignment

Layer / File(s)	Summary
extraEgress NetworkPolicy support `charts/apache/values.yaml`, `charts/apache/templates/networkpolicy.yaml`, `charts/apache/docs/networking.md`, `charts/apache/tests/networkpolicy_test.yaml`	Adds a new `extraEgress` values key (keeping `extraRules` for backward compatibility), renders it via `toYaml` in the NetworkPolicy template, documents it with an example, and adds a test verifying rendered egress rules.
NOTES.txt numbered sections `charts/apache/templates/NOTES.txt`	Renames nine section headings to numbered format (1. Installation summary through 9. Resources).
Test-connection Helm test suite `charts/apache/tests/test_connection_test.yaml`	Adds a new test suite asserting Pod name, hook annotation, and healthcheck command pattern for the test-connection template.

Estimated code review effort: 2 (Simple) | ~10 minutes

Related issues: #633 (fix: align 81 charts with template standards) — this PR addresses the netpol-missing-extra-egress and notes-no-numbered-sections warnings for the apache chart.

Suggested labels: chart:apache, template-standards

Suggested reviewers: helmforge-ops maintainers

🐰 A rabbit hopped through egress rules and NOTES,
Numbered each heading, cast off old quotes,
extraEgress now flows through YAML so neat,
Tests stand guard where standards must meet.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The PR addresses the linked Apache objectives by removing templates/tests usage and adding extraEgress support.
Out of Scope Changes check	✅ Passed	The remaining edits are documentation, NOTES, and tests that support the stated standards-alignment changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is broadly aligned with the Apache chart standards-related changes, including test relocation, NetworkPolicy updates, and NOTES/doc refinements.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/apache-template-standards

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-07-02T22:04:00Z

🟢 Security Scan: `apache`

Framework	Score
MITRE + NSA + SOC2	93.43434%

✅ Security posture acceptable.

## Summary - update the documented Apache image tag to 2.4.68 - document networkPolicy.egress.extraEgress in examples and the configuration reference - expose Apache in the playground registry for site-sync coverage - add curated Apache playground fields for networkPolicy.egress.extraEgress - guard Apache playground extraEgress serialization so partial rules are not emitted ## Validation - make site-sync-check CHART=apache - npm run lint - npm run format:check - npm run build - make release-check REPO=site - make attribution-check REPO=site Chart PR: helmforgedev/charts#641 (merged) Issue: helmforgedev/charts#633  ## Summary by CodeRabbit * **New Features** * Added the Apache chart to the playground’s selectable/syncable charts list. * Extended Apache NetworkPolicy egress with optional `networkPolicy.egress.extraEgress` inputs (extra CIDR, protocol, and port). * **Bug Fixes** * Prevented partial `extraEgress` inputs from being applied during playground sync. * **Documentation** * Updated Apache chart docs to pin the official `httpd` image to version `2.4.68`. * Expanded NetworkPolicy egress documentation with an `extraEgress` example and config reference updates, marking `extraRules` as legacy.

MergeCheck added 2 commits July 2, 2026 17:55

fix(apache): align template standards

2f7176d

fix(apache): complete template standards alignment

0722b8f

github-actions Bot added area:docs area:templates area:tests area:values chart:apache Issues related to the apache chart size:M labels Jul 2, 2026

mberlofa mentioned this pull request Jul 2, 2026

docs(apache): sync template standards helmforgedev/site#321

Merged

mberlofa mentioned this pull request Jul 2, 2026

fix: align 81 charts with template standards #633

Closed

mberlofa merged commit 6994164 into main Jul 3, 2026
18 checks passed

mberlofa deleted the fix/apache-template-standards branch July 3, 2026 09:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(apache): align template standards#641

fix(apache): align template standards#641
mberlofa merged 2 commits into
mainfrom
fix/apache-template-standards

mberlofa commented Jul 2, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

github-actions Bot commented Jul 2, 2026

Uh oh!

coderabbitai Bot commented Jul 2, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

github-actions Bot commented Jul 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

mberlofa commented Jul 2, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Summary by CodeRabbit

Uh oh!

github-actions Bot commented Jul 2, 2026

Standards Check (GR-079) — PASS

Uh oh!

coderabbitai Bot commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

github-actions Bot commented Jul 2, 2026

🟢 Security Scan: apache

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

mberlofa commented Jul 2, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 2, 2026 •

edited

Loading

🟢 Security Scan: `apache`